-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Boost 1.89: removed system stub, deadline_timer error #1838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Boost 1.89: removed system stub, deadline_timer error #1838
Conversation
|
And to fix cppressdk here: https://github.com/microsoft/cpprestsdk/blob/master/Release/cmake/cpprest_find_boost.cmake#L49 |
|
Sure there might be permutations of this depending on the target platform and similar. But just to confirm, it failed to find boost (specificly Boost::system) and removing Boost::system from the file fixed it? Just to clarify, I'm the maintainer of the FreeBSD port now, and I at least intermittently observed issues that were solved by the original patch while trying to build for the new FreeBSD 15.0 in december. |
Yes. Because boost_system is header only since a while (1.69) and the stub lib is now removed as you said. |
|
Yes, if you want me to add it to the PR, could you perhaps provide error messages for verification? Which platform are you building for? |
|
Linux Gentoo boost-1.89.0 cmake-4.2.1: |
|
Thanks. With boost-1.89 unmasked I guess. I'll probably be able to reproduce it as I am using Gentoo as well. |
…nux. Reported-By: Nicolas PARLANT
|
Also testing replacing deadline_timer (header not included, also deprecated) with steady_timer: /var/tmp/portage/dev-cpp/cpprestsdk-2.10.19-r8/work/cpprestsdk-2.10.19/Release/src/http/client/http_client_asio.cpp:470:18: error: ‘deadline_timer’ in namespace ‘boost::asio’ does not name a type |
since it is no longer included by the other includes anymore. But dealine_timer is deprecated, so I suggest replacing it with steady_timer like this.
|
With regards to Gentoo Linux I'm testing an updated patch for dev-cpp/cpprestsdk::guru . I have the changes staged locally so just test building with boost-1.88 now. I expect to commit the changes if they work with 1.88 as well within the next 24hrs to the guru dev-branch. |
Apparently the system stub was removed from boost 1.89. This causes projects depending on cpprestsdk to fail to build in case they use cmake to find and configure cpprestsdk.